Skip to content

python3Packages.miraie-ac: init at 1.1.1 #422479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mweinelt merged 3 commits into from
Aug 20, 2025
Merged

python3Packages.miraie-ac: init at 1.1.1 #422479

mweinelt merged 3 commits into from
Aug 20, 2025
+89 −0

Conversation

@ananthb
Copy link
Member

@ananthb ananthb commented Jul 4, 2025 •
edited
Loading

Added the miraie-ac python library.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@ananthb
Copy link
Member Author

ananthb commented Jul 4, 2025 •
edited
Loading

What command can I run to test building this library? I'm not sure how to generate the hash.

@nix-owners nix-owners bot requested a review from natsukium July 4, 2025 18:40
@ananthb
Copy link
Member Author

ananthb commented Jul 4, 2025

Also my maintainer addition commit is in this PR: #421056.
So once that's merged, the maintainer line in this PR should make sense.

@ananthb ananthb force-pushed the python-miraie-ac branch 2 times, most recently from 7e15fa4 to 78b19bc Compare July 4, 2025 18:47
@nixpkgs-ci nixpkgs-ci bot added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jul 4, 2025
@ananthb ananthb force-pushed the python-miraie-ac branch from 78b19bc to 89553f2 Compare July 5, 2025 11:05
@ananthb
Copy link
Member Author

ananthb commented Jul 5, 2025

It's building a wheel but now failing at:

      ...
       > Successfully built miraie_ac-1.1.1-py3-none-any.whl
       > Finished creating a wheel...
       > Finished executing pypaBuildPhase
       > Running phase: pythonRuntimeDepsCheckHook
       > Executing pythonRuntimeDepsCheck
       > Checking runtime dependencies for miraie_ac-1.1.1-py3-none-any.whl
       >   - asyncio not installed
       For full logs, run:
         nix log /nix/store/9a2awksv37nk0pq5ivxcgwq93szfhncl-python3.13-miraie_ac-1.1.1.drv

@ananthb ananthb requested a review from a user July 5, 2025 11:07
@ananthb ananthb changed the title miraie-ac: init at 1.1.1 miraie_ac: init at 1.1.1 Jul 5, 2025
@ananthb ananthb force-pushed the python-miraie-ac branch from 89553f2 to 2cc71ee Compare July 5, 2025 11:07
@nixpkgs-ci nixpkgs-ci bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jul 5, 2025
@ghost ghost removed their request for review July 5, 2025 20:42
@ananthb ananthb force-pushed the python-miraie-ac branch from 2cc71ee to b1aba68 Compare July 6, 2025 06:03
@ananthb ananthb requested a review from a user July 9, 2025 20:23
@ananthb ananthb force-pushed the python-miraie-ac branch from b1aba68 to 7a31127 Compare July 9, 2025 21:32
@ananthb ananthb requested a review from a user July 9, 2025 21:33
@ananthb ananthb changed the title miraie_ac: init at 1.1.1 miraie-ac: init at 1.1.1 Jul 9, 2025
@ananthb ananthb force-pushed the python-miraie-ac branch from 7a31127 to 1f38603 Compare July 9, 2025 21:38
@ananthb
Copy link
Member Author

ananthb commented Jul 9, 2025

@emaryn done

@ananthb ananthb force-pushed the python-miraie-ac branch from 1f38603 to 7e501af Compare July 9, 2025 21:39
@ananthb ananthb changed the title miraie-ac: init at 1.1.1 python3Package.miraie-ac: init at 1.1.1 Jul 9, 2025
@ananthb ananthb changed the title python3Package.miraie-ac: init at 1.1.1 python3Packages.miraie-ac: init at 1.1.1 Jul 9, 2025
@ananthb ananthb force-pushed the python-miraie-ac branch from 7e501af to f25e29b Compare July 9, 2025 21:40
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 9, 2025
@ghost ghost removed their request for review July 11, 2025 21:09
@ananthb ananthb force-pushed the python-miraie-ac branch from aeb18c5 to a329fe9 Compare July 25, 2025 21:18
@ananthb ananthb requested review from Pandapip1 and drupol July 25, 2025 21:19
@ananthb
Copy link
Member Author

ananthb commented Jul 25, 2025

I'm not sure how to fix this error:

error: builder for '/nix/store/1h0bskbfn9759wrjlv678m0s8avyl3nh-python3.13-rkzofficial-miraie-1.1.5.drv' failed with exit code 1;
       last 25 log lines:
       > unpacking source archive /nix/store/wgmcdff48m1x47midn82x85fhh0bwf5h-source
       > source root is source
       > setting SOURCE_DATE_EPOCH to timestamp 315619200 of file "source/info.md"
       > Running phase: patchPhase
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > no configure script, doing nothing
       > Running phase: buildPhase
       > Running phase: installPhase
       > Running phase: fixupPhase
       > shrinking RPATHs of ELF executables and libraries in /nix/store/qc7ch6fgdl8vsvyy9wnd55jk8wsfhah1-python3.13-rkzofficial-miraie-1.1.5
       > checking for references to /build/ in /nix/store/qc7ch6fgdl8vsvyy9wnd55jk8wsfhah1-python3.13-rkzofficial-miraie-1.1.5...
       > patching script interpreter paths in /nix/store/qc7ch6fgdl8vsvyy9wnd55jk8wsfhah1-python3.13-rkzofficial-miraie-1.1.5
       > Executing pythonRemoveTestsDir
       > Finished executing pythonRemoveTestsDir
       > Running phase: installCheckPhase
       > no Makefile or custom installCheckPhase, doing nothing
       > Running phase: pythonCatchConflictsPhase
       > Running phase: pythonRemoveBinBytecodePhase
       > Running phase: pythonImportsCheckPhase
       > Executing pythonImportsCheckPhase
       > Running phase: manifestCheckPhase
       > Executing manifestCheckPhase
       > Checking manifests ./custom_components/miraie/manifest.json
       >   - asyncio>=3.4.3 not installed
       For full logs, run:
         nix log /nix/store/1h0bskbfn9759wrjlv678m0s8avyl3nh-python3.13-rkzofficial-miraie-1.1.5.drv

@mweinelt
Copy link
Member

mweinelt commented Jul 25, 2025

This version is only relevant for Python 3.3, which does not include asyncio in its stdlib.

https://pypi.org/project/asyncio/

pythonRemoveDeps = [ "asyncio" ];

drupol
drupol reviewed Jul 26, 2025
View reviewed changes
@ananthb ananthb force-pushed the python-miraie-ac branch from a329fe9 to 4312436 Compare July 26, 2025 07:23
@ananthb
Copy link
Member Author

ananthb commented Jul 26, 2025

@mweinelt I had pythonRemoveDeps = [ "asyncio" ]; already. I'm getting the error despite that.

@ananthb ananthb force-pushed the python-miraie-ac branch from 4312436 to 42e0427 Compare July 26, 2025 07:31
@ananthb ananthb requested a review from drupol July 26, 2025 07:31
mweinelt
mweinelt reviewed Jul 26, 2025
View reviewed changes
@ananthb ananthb force-pushed the python-miraie-ac branch from 42e0427 to f7561b8 Compare July 26, 2025 15:09
@ananthb ananthb requested a review from mweinelt July 26, 2025 15:10
@ananthb ananthb mentioned this pull request Jul 27, 2025
Closed
@Pandapip1 Pandapip1 mentioned this pull request Jul 30, 2025
Open
13 tasks
@ananthb ananthb force-pushed the python-miraie-ac branch 3 times, most recently from b69ac46 to 2c43cf8 Compare August 18, 2025 21:55
@nixos-discourse
Copy link

nixos-discourse commented Aug 18, 2025

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5776

mweinelt
mweinelt reviewed Aug 19, 2025
View reviewed changes
@ananthb ananthb requested a review from mweinelt August 19, 2025 17:58
@mweinelt mweinelt enabled auto-merge August 20, 2025 00:55
@mweinelt mweinelt merged commit b40f6ad into NixOS:master Aug 20, 2025
25 of 28 checks passed
@ananthb ananthb deleted the python-miraie-ac branch August 20, 2025 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt mweinelt approved these changes

@natsukium natsukium Awaiting requested review from natsukium

@Pandapip1 Pandapip1 Awaiting requested review from Pandapip1

@drupol drupol Awaiting requested review from drupol

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ananthb @nixos-discourse @mweinelt @drupol @Pandapip1